BukrosSzabolcs commented on a change in pull request #592: HBASE-22982: region
server suspend/resume and graceful rolling restart actions
URL: https://github.com/apache/hbase/pull/592#discussion_r328097760
##########
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java
##########
@@ -150,78 +151,106 @@ public void perform() throws Exception { }
}
protected void killMaster(ServerName server) throws IOException {
- LOG.info("Killing master " + server);
+ LOG.info("Killing master {}", server);
cluster.killMaster(server);
cluster.waitForMasterToStop(server, killMasterTimeout);
LOG.info("Killed master " + server);
}
protected void startMaster(ServerName server) throws IOException {
- LOG.info("Starting master " + server.getHostname());
+ LOG.info("Starting master {}", server.getHostname());
cluster.startMaster(server.getHostname(), server.getPort());
cluster.waitForActiveAndReadyMaster(startMasterTimeout);
LOG.info("Started master " + server.getHostname());
}
+ protected void stopRs(ServerName server) throws IOException {
+ LOG.info("Stopping regionserver {}", server);
+ cluster.stopRegionServer(server);
+ cluster.waitForRegionServerToStop(server, killRsTimeout);
+ LOG.info("Stoppiong regionserver {}. Reported num of rs:{}", server,
+ cluster.getClusterMetrics().getLiveServerMetrics().size());
+ }
+
+ protected void suspendRs(ServerName server) throws IOException {
+ LOG.info("Suspending regionserver {}", server);
+ cluster.suspendRegionServer(server);
+ if(!(cluster instanceof MiniHBaseCluster)){
Review comment:
We send a SIGSTOP and then make sure the process is suspended before we
continue. For MiniCluster it makes no sense to it because we just suspend the
thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
