ramkrish86 commented on a change in pull request #652: HBASE-23035 Retain
region to the last RegionServer make the failover …
URL: https://github.com/apache/hbase/pull/652#discussion_r328447962
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java
##########
@@ -172,11 +172,11 @@ protected boolean waitInitialized(MasterProcedureEnv
env) {
private void queueAssign(MasterProcedureEnv env, RegionStateNode regionNode)
throws ProcedureSuspendedException {
- // Here the assumption is that, the region must be in CLOSED state, so the
region location
- // will be null. And if we fail to open the region and retry here, the
forceNewPlan will be
- // true, and also we will set the region location to null.
boolean retain = false;
- if (!forceNewPlan) {
+ if (forceNewPlan) {
Review comment:
Have you done any other commit prior to this change? Seems currently
TransitRegionStateProcedure does not get called with forceNewPlan = true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
