[ 
https://issues.apache.org/jira/browse/HBASE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247717#comment-13247717
 ] 

Hadoop QA commented on HBASE-5722:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521579/HBASE-5722.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1414//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1414//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1414//console

This message is automatically generated.
                
> NPE in ZKUtil#getChildDataAndWatchForNewChildren when ZK not available or NW 
> down.
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-5722
>                 URL: https://issues.apache.org/jira/browse/HBASE-5722
>             Project: HBase
>          Issue Type: Bug
>          Components: zookeeper
>    Affects Versions: 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HBASE-5722.patch
>
>
> {code}
> List<String> nodes =
>       ZKUtil.listChildrenAndWatchForNewChildren(zkw, baseNode);
>     List<NodeAndData> newNodes = new ArrayList<NodeAndData>();
>     for (String node: nodes) {
>       String nodePath = ZKUtil.joinZNode(baseNode, node);
>       byte [] data = ZKUtil.getDataAndWatch(zkw, nodePath);
>       newNodes.add(new NodeAndData(nodePath, data));
>     }
> {code}
> The above code can throw NPE when listChildrenAndWatchForNewChildren returns 
> null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to