[
https://issues.apache.org/jira/browse/HBASE-23038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939953#comment-16939953
]
Hudson commented on HBASE-23038:
--------------------------------
Results for branch branch-1
[build #1088 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1088//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Provide consistent and clear logging about disabling chores
> -----------------------------------------------------------
>
> Key: HBASE-23038
> URL: https://issues.apache.org/jira/browse/HBASE-23038
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Reporter: Sean Busbey
> Assignee: Sanjeet Nishad
> Priority: Minor
> Labels: beginner
> Fix For: 3.0.0, 1.5.0, 2.3.0
>
> Attachments: HBASE-23038.001.patch, HBASE-23038.002.patch,
> HBASE-23038.master.003.patch
>
>
> Right now if you want to disable any of our chores you can set the period to
> be <= 0. Sometimes, if you do this you get a nice message:
> {code}
> 2019-09-16 22:10:16,756 INFO [master-1:16000.activeMasterManager]
> master.HMaster: The period is 0 seconds, MobCompactionChore is disabled
> {code}
> And sometimes you get an opaque message:
> {code}
> 2019-09-16 22:09:45,333 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: LogsCleaner
> 2019-09-16 22:09:45,340 INFO [master-1:16000.activeMasterManager]
> hbase.ChoreService: Could not successfully schedule chore: HFileCleaner
> {code}
> This is because sometimes we just blindly submit to ChoreService which
> submits to a java ScheduledExecutorService and then catches the
> IllegalArgumentException.
> We should remove the one-offs and make it so ChoreService checks the period
> before accepting a submittal and produces a consistent "Foo is disabled"
> message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
