chenxu14 commented on a change in pull request #664: HBASE-23083 Collect
Executor status info periodically and report to metric system
URL: https://github.com/apache/hbase/pull/664#discussion_r329317673
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1922,6 +1926,14 @@ private void startServices() throws IOException {
HConstants.DEFAULT_THREAD_WAKE_FREQUENCY);
healthCheckChore = new HealthCheckChore(sleepTime, this,
getConfiguration());
}
+ // Executor status collect thread.
+ if (this.conf.getBoolean(HConstants.EXECUTOR_STATUS_COLLECTE_ENABLED,
+ HConstants.DEFAULT_EXECUTOR_STATUS_COLLECTE_ENABLED)) {
+ int sleepTime = this.conf.getInt(ExecutorStatusChore.WAKE_FREQ,
+ ExecutorStatusChore.DEFAULT_WAKE_FREQ);
+ executorStatusChore = new ExecutorStatusChore(sleepTime, this,
this.getExecutorService(),
Review comment:
Hi Stack, maybe I misunderstood it. I mead there is only one
ExecutorService, but it will start many Executors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
