[
https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940341#comment-16940341
]
Viraj Jasani commented on HBASE-23093:
--------------------------------------
{quote}if we do not use Optional field, then we need to call
Optional.ofNullable everytime...
{quote}
Agree, this can also lead to unnecessary computation. Unless we want to
serialize the field, we are good with optional field.
> Avoid Optional Anti-Patterns
> ----------------------------
>
> Key: HBASE-23093
> URL: https://issues.apache.org/jira/browse/HBASE-23093
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.3.0, 1.6.0
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
>
> Optional should be used as a return type only. It's a neat solution for
> handling data that might not be present. We should avoid using Optional
> Anti-Patterns i.e. using it as a field or parameter type due to these reasons:
> 1. Using Optional parameters causing conditional logic inside the methods is
> not productive.
> 2. Packing an argument in an Optional is suboptimal for the compiler and does
> an unnecessary wrapping.
> 3. Optional field is not serializable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
