[
https://issues.apache.org/jira/browse/HBASE-22902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941168#comment-16941168
]
Andrew Kyle Purtell commented on HBASE-22902:
---------------------------------------------
The patch is for branch-1 I think.
Anyway the changes lgtm. I will try to apply this today. Will come back here if
local checks fail for some reason.
> At regionserver start there's a request to roll the WAL
> -------------------------------------------------------
>
> Key: HBASE-22902
> URL: https://issues.apache.org/jira/browse/HBASE-22902
> Project: HBase
> Issue Type: Bug
> Components: wal
> Affects Versions: 3.0.0, 1.5.0, 2.3.0
> Reporter: David Manning
> Assignee: Sandeep Pal
> Priority: Minor
> Attachments: HBASE-22902_branch-1_v1.patch
>
>
> See HBASE-22301 for logic that requests to roll the WAL if regionserver
> encounters a slow write pipeline. In the logs, during regionserver start, I
> see that the WAL is requested to roll once. It's strange that we roll the WAL
> because it wasn't a slow sync. It appears when this code executes, we haven't
> initialized the {{rollOnSyncNs}} variable to use for determining whether it's
> a slow sync. Current pipeline also shows empty in the logs.
> Disclaimer: I'm experiencing this after backporting this to 1.3.x and
> building it there - I haven't attempted in 1.5.x, though I'd expect similar
> results.
> Regionserver logs follow (notice *threshold=0 ms, current pipeline: []*):
> {noformat}
> Tue Aug 20 23:29:50 GMT 2019 Starting regionserver
> ...
> 2019-08-20 23:29:57,824 INFO wal.FSHLog - WAL configuration: blocksize=256
> MB, rollsize=243.20 MB, prefix=[truncated]%2C1566343792434, suffix=,
> logDir=hdfs://[truncated]/hbase/WALs/[truncated],1566343792434,
> archiveDir=hdfs://[truncated]/hbase/oldWALs
> 2019-08-20 23:29:58,104 INFO wal.FSHLog - Slow sync cost: 186 ms, current
> pipeline: []
> 2019-08-20 23:29:58,104 WARN wal.FSHLog - Requesting log roll because we
> exceeded slow sync threshold; time=186 ms, threshold=0 ms, current pipeline:
> []
> 2019-08-20 23:29:58,107 DEBUG regionserver.ReplicationSourceManager - Start
> tracking logs for wal group [truncated]%2C1566343792434 for peer 1
> 2019-08-20 23:29:58,107 INFO wal.FSHLog - New WAL
> /hbase/WALs/[truncated],1566343792434/[truncated]%2C1566343792434.1566343797824
> 2019-08-20 23:29:58,109 DEBUG regionserver.ReplicationSource - Starting up
> worker for wal group [truncated]%2C1566343792434{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
