[ 
https://issues.apache.org/jira/browse/HBASE-23100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941193#comment-16941193
 ] 

Michael Stack commented on HBASE-23100:
---------------------------------------

I made an RC0 using dev-tools/create-release from hbase master branch but it 
mangled the maven repository deploy leaving out the parent. The later was done 
intentionally thinking it unnecessary. RC1 puts back inclusion of parent module 
(had to make fix to the create-release scripts in new version of patch that is 
up on HBASE-23092.

Here is how I verified RC1 changing hbase core to build using it:
{code}
$ git diff
diff --git a/hbase-common/pom.xml b/hbase-common/pom.xml
index c23b9d4dd3..55395630bd 100644
--- a/hbase-common/pom.xml
+++ b/hbase-common/pom.xml
@@ -150,6 +150,10 @@
       <groupId>org.apache.hbase.thirdparty</groupId>
       <artifactId>hbase-shaded-miscellaneous</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hbase.thirdparty</groupId>
+      <artifactId>hbase-shaded-gson</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.apache.hbase.thirdparty</groupId>
       <artifactId>hbase-shaded-netty</artifactId>
diff --git a/pom.xml b/pom.xml
index 5029cc9a19..ad6fb50222 100755
--- a/pom.xml
+++ b/pom.xml
@@ -1531,7 +1531,7 @@
     <surefire.version>2.22.2</surefire.version>
     <wagon.ssh.version>2.12</wagon.ssh.version>
     <xml.maven.version>1.0.1</xml.maven.version>
-    <hbase-thirdparty.version>2.2.1</hbase-thirdparty.version>
+    <hbase-thirdparty.version>3.1.0</hbase-thirdparty.version>
     <!-- Intraproject jar naming properties -->
     <!-- TODO this is pretty ugly, but works for the moment.
       Modules are pretty heavy-weight things, so doing this work isn't too 
bad. -->
@@ -2248,6 +2248,11 @@
         <artifactId>audience-annotations</artifactId>
         <version>${audience-annotations.version}</version>
       </dependency>
+      <dependency>
+        <groupId>org.apache.hbase.thirdparty</groupId>
+        <artifactId>hbase-shaded-gson</artifactId>
+        <version>${hbase-thirdparty.version}</version>
+      </dependency>
       <dependency>
         <groupId>org.apache.hbase.thirdparty</groupId>
         <artifactId>hbase-shaded-miscellaneous</artifactId>
@@ -4047,4 +4052,11 @@
       <url>file:///tmp</url>
     </site>
   </distributionManagement>
+  <repositories>
+    <repository>
+      <id>my-repo2</id>
+      <name>your custom repo</name>
+      
<url>https://repository.apache.org/content/repositories/orgapachehbase-1353/</url>
+    </repository>
+  </repositories>
 </project>
{code}



> Make a 3.1.0 hbase-thirdparty release
> -------------------------------------
>
>                 Key: HBASE-23100
>                 URL: https://issues.apache.org/jira/browse/HBASE-23100
>             Project: HBase
>          Issue Type: Task
>          Components: hbase-thirdparty
>            Reporter: Michael Stack
>            Assignee: Michael Stack
>            Priority: Major
>
> Make a hbase-thirdparty release. 3.0.0 broke out a gson module out of the 
> miscellaneous where it used live. 3.1.0 is about updating the dependencies in 
> hbase-thirdparty.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to