steveloughran commented on a change in pull request #9: HBASE-23099 - [HBOSS]
Raise hadoop dependency version to 3.2.1
URL: https://github.com/apache/hbase-filesystem/pull/9#discussion_r329749504
##########
File path:
hbase-oss/src/test/java/org/apache/hadoop/hbase/oss/contract/TestHBOSSContractRootDirectory.java
##########
@@ -34,6 +36,14 @@ protected Configuration createConfiguration() {
@Override
protected AbstractFSContract createContract(Configuration conf) {
- return new HBOSSContract(conf);
+ HBOSSContract contract = new HBOSSContract(conf);
+ try {
+ TestUtils.getFileSystem(conf);
+ } catch (Exception e) {
+ e.printStackTrace();
+ fail("Exception configuring FS: " + e);
Review comment:
better: throw and Assertion error with the inner cause. And given it's
commonality, share this code across the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
