petersomogyi commented on a change in pull request #671: HBASE-23092 Make the 
RM tooling in dev-tools/create-release generic
URL: https://github.com/apache/hbase/pull/671#discussion_r329957686
 
 

 ##########
 File path: dev-support/create-release/do-release-docker.sh
 ##########
 @@ -152,13 +158,13 @@ EOF
 
 JAVA_VOL=
 if [ -n "$JAVA" ]; then
-  echo "JAVA_HOME=/opt/hbase-java" >> $ENVFILE
+  echo "JAVA_HOME=/opt/hbase-java" >> "$ENVFILE"
   JAVA_VOL="--volume $JAVA:/opt/hbase-java"
 fi
 
 echo "Building $RELEASE_TAG; output will be at $WORKDIR/output"
 docker run -ti \
   --env-file "$ENVFILE" \
   --volume "$WORKDIR:/opt/hbase-rm" \
-  $JAVA_VOL \
+  "$JAVA_VOL" \
 
 Review comment:
   Same problem here. See 
[#34](https://github.com/apache/hbase-operator-tools/pull/34)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to