wchevreuil commented on a change in pull request #9: HBASE-23099 - [HBOSS]
Raise hadoop dependency version to 3.2.1
URL: https://github.com/apache/hbase-filesystem/pull/9#discussion_r330006697
##########
File path:
hbase-oss/src/test/java/org/apache/hadoop/hbase/oss/contract/TestHBOSSContractRootDirectory.java
##########
@@ -34,6 +36,14 @@ protected Configuration createConfiguration() {
@Override
protected AbstractFSContract createContract(Configuration conf) {
- return new HBOSSContract(conf);
+ HBOSSContract contract = new HBOSSContract(conf);
+ try {
+ TestUtils.getFileSystem(conf);
+ } catch (Exception e) {
+ e.printStackTrace();
+ fail("Exception configuring FS: " + e);
Review comment:
Maybe make _TestUtils.getFileSystem(conf)_ throw _AssertionError_, since
it's a basic test requirement? That would simplify this check for the subset of
tests requiring it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
