wchevreuil commented on a change in pull request #677: HBASE-23073 Add an optional costFunction to balance regions according to a capacity rule URL: https://github.com/apache/hbase/pull/677#discussion_r330904090
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ########## @@ -654,6 +654,22 @@ protected double computeCost(Cluster cluster, double previousCost) { return total; } + /** Review comment: Is this method really needed? It appears to be used on a test only, just to assert the related cost function was loaded, but maybe we can just assert the expected result for the cost function, instead of checking internals of StochasticLoadBalancer. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services