wchevreuil commented on a change in pull request #677: HBASE-23073 Add an
optional costFunction to balance regions according to a capacity rule
URL: https://github.com/apache/hbase/pull/677#discussion_r330980810
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
##########
@@ -486,18 +497,22 @@ protected void returnRegions(List<RegionInfo> regions) {
private Queue<ServerName> serverQueue = new LinkedList<>();
- protected ServerAndLoad randomServer(final int numRegionsPerServer) {
+ protected ServerAndLoad randomServer(final int numRegionsPerServer, final
String host) {
Review comment:
Change this method name? As we specify the host, does not look we are
choosing server randomly. Or maybe I'm confusing things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
