SteNicholas commented on a change in pull request #679: HBASE-23113 IPC Netty
Optimization
URL: https://github.com/apache/hbase/pull/679#discussion_r331744013
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -257,6 +258,7 @@ private void connect() {
.option(ChannelOption.TCP_NODELAY, rpcClient.isTcpNoDelay())
.option(ChannelOption.SO_KEEPALIVE, rpcClient.tcpKeepAlive)
.option(ChannelOption.CONNECT_TIMEOUT_MILLIS, rpcClient.connectTO)
+ .option(ChannelOption.WRITE_BUFFER_WATER_MARK, new
WriteBufferWaterMark(rpcClient.bufferLowWatermark,
rpcClient.bufferHighWatermark))
Review comment:
> Create a WriteBufferWaterMark and store it in NettyRpcClient so we do not
need to create it everytime?
There is really no need to create a WriteBufferWaterMark every time.I will
modify this definition in NettyRpcConnection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
