virajjasani commented on a change in pull request #690: HBASE-23123
Merge_region fails from shell
URL: https://github.com/apache/hbase/pull/690#discussion_r331800472
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -533,9 +533,12 @@ def move(encoded_region_name, server = nil)
#----------------------------------------------------------------------------------------------
# Merge two regions
def merge_region(region_a_name, region_b_name, force)
- @admin.mergeRegions(region_a_name.to_java_bytes,
- region_b_name.to_java_bytes,
- java.lang.Boolean.valueOf(force))
+ @admin.mergeRegionsAsync(
+ region_a_name.to_java_bytes,
+ region_b_name.to_java_bytes,
+ java.lang.Boolean.valueOf(force)
+ )
+ return nil
Review comment:
return statement is redundant it seems? as of now this is called by only
merge_region.rb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
