karthikhw edited a comment on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538773133 @Apache9 @virajjasani It looks to me no test method defined for merge_region. I see only few test from admin_test.rb but not all shell commands included in that test. I think that's our gap. I just ran admin_test.rb test but somehow it is failing. Let me check. However, I am not sure if maven skip running this test ?? When I run "mvn test" on "hbase-shell" module, it only runs two test classes and reports success but I don't find all of them are running. This is weird. I will check on this today. [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.622 s - in org.apache.hadoop.hbase.client.TestShellNoCluster [INFO] Running org.apache.hadoop.hbase.client.TestTableShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.476 s - in org.apache.hadoop.hbase.client.TestTableShell [INFO] [INFO] Results: [INFO] [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 @virajjasani "return statement is redundant" is a warning of ruby check style. This is about I return "nil" without any variable check, something like "if (var > x) else return nil" etc. I directly return nil in script because the method mergeRegionsAsync returns void. Future<Void> mergeRegionsAsync(byte[] nameOfRegionA, byte[] nameOfRegionB, boolean forcible) throws IOException { If I don't use nil, then I will get CompletableFuture output. => #<Java::JavaUtilConcurrent::CompletableFuture:0x68631b1d> Example: hbase(main):001:0> merge_region '39ac83efe7b96b875d0a9e63313a3717','ff68d30015dc2565eaea1a16207e2e91' Took 0.9494 seconds => #<Java::JavaUtilConcurrent::CompletableFuture:0x68631b1d>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
