virajjasani edited a comment on issue #690: HBASE-23123 Merge_region fails from shell URL: https://github.com/apache/hbase/pull/690#issuecomment-538774132 > I directly return nil in script because the method mergeRegionsAsync returns void. Correct, just realized by default async method's return value will be passed on to merge_region.rb. Regarding the tests, better to include test for merge_region() with this PR. And I agree that "mvn test" doesn't run all tests for hbase-shell and we have to manually run them as of now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
