Apache9 commented on a change in pull request #673: HBASE-23093 : Avoid
Optional Anti-Pattern where possible
URL: https://github.com/apache/hbase/pull/673#discussion_r332387220
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##########
@@ -582,9 +585,9 @@ static int getPriority(TableName tableName) {
}
}
- static void updateStats(Optional<ServerStatisticTracker> optStats,
- Optional<MetricsConnection> optMetrics, ServerName serverName,
MultiResponse resp) {
- if (!optStats.isPresent() && !optMetrics.isPresent()) {
+ static void updateStats(ServerStatisticTracker serverStatisticTracker,
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
