saintstack commented on a change in pull request #656: HBASE-23063 Add an
option to enable multiget in parallel
URL: https://github.com/apache/hbase/pull/656#discussion_r333168029
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -788,31 +791,28 @@ private Result increment(final HRegion region, final
OperationQuota quota,
List<ClientProtos.Action> mutations = null;
long maxQuotaResultSize = Math.min(maxScannerResultSize,
quota.getReadAvailable());
IOException sizeIOE = null;
- Object lastBlock = null;
- ClientProtos.ResultOrException.Builder resultOrExceptionBuilder =
ResultOrException.newBuilder();
+ List<GetContext> getCtxs = new ArrayList<>();
+ if (cellsToReturn == null && isClientCellBlockSupport(context)) {
+ cellsToReturn = new ArrayList<CellScannable>();
+ }
+ ResultOrException.Builder resultOrExceptionBuilder =
ResultOrException.newBuilder();
boolean hasResultOrException = false;
for (ClientProtos.Action action : actions.getActionList()) {
hasResultOrException = false;
resultOrExceptionBuilder.clear();
try {
Result r = null;
-
- if (context != null
- && context.isRetryImmediatelySupported()
- && (context.getResponseCellSize() > maxQuotaResultSize
- || context.getResponseBlockSize() +
context.getResponseExceptionSize()
- > maxQuotaResultSize)) {
-
+ if (isRpcCallAboveQuota(context, maxQuotaResultSize, true)) {
Review comment:
Good change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
