[
https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949798#comment-16949798
]
Hudson commented on HBASE-23115:
--------------------------------
Results for branch branch-2.2
[build #659 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/659//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Unit change for StoreFileSize and MemStoreSize
> ----------------------------------------------
>
> Key: HBASE-23115
> URL: https://issues.apache.org/jira/browse/HBASE-23115
> Project: HBase
> Issue Type: Bug
> Components: metrics, UI
> Affects Versions: 3.0.0
> Reporter: Karthik Palanisamy
> Assignee: Karthik Palanisamy
> Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
> Attachments: Units.pdf
>
>
> StoreFileSize and MemstoreSize usually returned in MBs (link1, link2) but
> few jsp pages contain inaccurate unit. The reason is table.jsp (link3) use
> org.apache.hadoop.util.StringUtils.byteDesc(long len), this will perform
> longtostring conversion and returns its unit(B, KB, MB, GB, TB, PB) based on
> length. The concern here (link4) is computation (ByteVal/1024/1024) will
> output always lesser than 1 for store contains few bytes or few kbs. Also,
> typecast will not round up to its nearest value.
> I think the best option is changing unit in table.jsp instead of changing
> code, otherwise we may end up doing many refactors from getMemStoreSizeMB,
> setMemStoreSizeMB, hasMemStoreSizeMB, getStorefileSizeMB,
> setStorefileSizeMB,..
>
> Please find the attachment, a simple example is posted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
