[
https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949852#comment-16949852
]
David Manning commented on HBASE-23153:
---------------------------------------
Thanks [~apurtell] for doing literally all the work. I made a comment on the
github PR about keeping the {{cost}} method as is. Otherwise LGTM
> PrimaryRegionCountSkewCostFunction SLB function should implement
> CostFunction#isNeeded
> --------------------------------------------------------------------------------------
>
> Key: HBASE-23153
> URL: https://issues.apache.org/jira/browse/HBASE-23153
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.6.0, 2.2.2, 2.1.8, 1.5.1
>
>
> The PrimaryRegionCountSkewCostFunction SLB function should implement
> CostFunction#isNeeded and like the other region replica specific functions
> should return false for it when region replicas are not in use. Otherwise it
> will always report a cost of 0 even though its weight will be included in the
> sum of the weights.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
