apurtell commented on a change in pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded URL: https://github.com/apache/hbase/pull/714#discussion_r334213281
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ########## @@ -1236,11 +1236,13 @@ protected double cost() { DEFAULT_PRIMARY_REGION_COUNT_SKEW_COST)); } + @Override + boolean isNeeded() { + return cluster.hasRegionReplicas; + } + @Override protected double cost() { - if (!cluster.hasRegionReplicas) { Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services