wchevreuil commented on a change in pull request #712: HBASE-23136
URL: https://github.com/apache/hbase/pull/712#discussion_r334244944
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFiles.java
##########
@@ -84,6 +84,10 @@ public Path getFilePath() {
Map<LoadQueueItem, ByteBuffer> bulkLoad(TableName tableName, Map<byte[],
List<Path>> family2Files)
throws TableNotFoundException, IOException;
+ /**
+ * Disable replication for this bulkload, if bulkload replication is
configured.
+ */
+ void disableReplication();
Review comment:
> Also, since this is directly user facing, would a isReplicationDisabled()
getter be a good idea?
Done
> This is Public so we need to be careful what branch this lands in, right?
Right! For master, should be ok. For branch-2, maybe add a _default static
BulkLoadHFiles createNoReplication(Configuration conf)_ whose implementation
already takes care of disabling it, without having to define that abstract
_disableReplication()_ method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
