[
https://issues.apache.org/jira/browse/HBASE-23107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950657#comment-16950657
]
Zheng Hu commented on HBASE-23107:
----------------------------------
[~javaman_chen], Did you mind to provide some perf data to show the GC
pressure decrement ? Maybe the async-profiler heap flamegraph can be the
proof ... Will be glad to see that if have one .
Thanks.
> Avoid temp byte array creation when doing cacheDataOnWrite
> ----------------------------------------------------------
>
> Key: HBASE-23107
> URL: https://issues.apache.org/jira/browse/HBASE-23107
> Project: HBase
> Issue Type: Improvement
> Reporter: chenxu
> Assignee: chenxu
> Priority: Major
>
> code in HFileBlock.Writer.cloneUncompressedBufferWithHeader
> {code:java}
> ByteBuffer cloneUncompressedBufferWithHeader() {
> expectState(State.BLOCK_READY);
> byte[] uncompressedBlockBytesWithHeader = baosInMemory.toByteArray();
> …
> }
> {code}
> When cacheOnWrite feature enabled, a temp byte array was created in order to
> copy block’s data, we can avoid this by use of ByteBuffAllocator. This can
> improve GC performance in write heavy scenarios.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
