chenxu14 commented on a change in pull request #678: HBASE-23107 Avoid temp
byte array creation when doing cacheDataOnWrite
URL: https://github.com/apache/hbase/pull/678#discussion_r334316983
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
##########
@@ -1012,6 +1021,18 @@ private void putHeader(byte[] dest, int offset, int
onDiskSize,
Bytes.putInt(dest, offset, onDiskDataSize);
}
+ private void putHeader(ByteBuff buff, int onDiskSize,
Review comment:
you mean wrap the dest like this?
**ByteBuff.wrap(ByteBuffer.wrap(dest))**
Will create extra ByteBuffer and ByteBuff instance, not friendly to YGC?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
