joshelser commented on a change in pull request #712: HBASE-23136
URL: https://github.com/apache/hbase/pull/712#discussion_r334637475
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFiles.java
##########
@@ -84,6 +84,10 @@ public Path getFilePath() {
Map<LoadQueueItem, ByteBuffer> bulkLoad(TableName tableName, Map<byte[],
List<Path>> family2Files)
throws TableNotFoundException, IOException;
+ /**
+ * Disable replication for this bulkload, if bulkload replication is
configured.
+ */
+ void disableReplication();
Review comment:
> For branch-2, maybe add a default static BulkLoadHFiles
createNoReplication(Configuration conf) whose implementation already takes care
of disabling it, without having to define that abstract disableReplication()
method?
Sounds like a plan!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
