Apache-HBase commented on issue #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs URL: https://github.com/apache/hbase/pull/722#issuecomment-542000506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | :blue_heart: | reexec | 2m 22s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :blue_heart: | prototool | 0m 0s | prototool was not available. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 8 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 45s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 7m 31s | master passed | | :green_heart: | compile | 3m 39s | master passed | | :green_heart: | checkstyle | 3m 15s | master passed | | :green_heart: | shadedjars | 5m 43s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 2m 41s | master passed | | :blue_heart: | spotbugs | 5m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 12m 10s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 21s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 6m 39s | the patch passed | | :green_heart: | compile | 3m 33s | the patch passed | | :green_heart: | cc | 3m 33s | the patch passed | | :green_heart: | javac | 3m 33s | the patch passed | | :broken_heart: | checkstyle | 0m 14s | hbase-hadoop-compat: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :broken_heart: | checkstyle | 0m 13s | hbase-hadoop2-compat: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) | | :broken_heart: | checkstyle | 0m 34s | hbase-client: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0) | | :broken_heart: | checkstyle | 1m 32s | hbase-server: The patch generated 16 new + 62 unchanged - 0 fixed = 78 total (was 62) | | :broken_heart: | checkstyle | 0m 13s | hbase-hbtop: The patch generated 38 new + 0 unchanged - 0 fixed = 38 total (was 0) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 23s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | hbaseprotoc | 3m 15s | the patch passed | | :broken_heart: | javadoc | 0m 15s | hbase-hadoop-compat generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | :broken_heart: | javadoc | 0m 36s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :broken_heart: | javadoc | 0m 15s | hbase-hbtop generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0) | | :broken_heart: | findbugs | 0m 39s | hbase-hadoop2-compat generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | :broken_heart: | findbugs | 1m 17s | hbase-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | :broken_heart: | findbugs | 4m 44s | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | :green_heart: | unit | 0m 42s | hbase-protocol-shaded in the patch passed. | | :green_heart: | unit | 0m 31s | hbase-hadoop-compat in the patch passed. | | :green_heart: | unit | 0m 37s | hbase-hadoop2-compat in the patch passed. | | :green_heart: | unit | 0m 25s | hbase-protocol in the patch passed. | | :green_heart: | unit | 1m 50s | hbase-client in the patch passed. | | :broken_heart: | unit | 30m 50s | hbase-server in the patch failed. | | :green_heart: | unit | 0m 47s | hbase-hbtop in the patch passed. | | :green_heart: | asflicense | 1m 37s | The patch does not generate ASF License warnings. | | | | 137m 31s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hbase-hadoop2-compat | | | Should org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl$ClientMetricsImpl be a _static_ inner class? At MetricsUserSourceImpl.java:inner class? At MetricsUserSourceImpl.java:[lines 72-96] | | FindBugs | module:hbase-client | | | Unused field:UserMetricsBuilder.java | | | Unused field:UserMetricsBuilder.java | | FindBugs | module:hbase-server | | | Dead store to metricsCollector in org.apache.hadoop.hbase.regionserver.HRegionServer.buildServerLoad(long, long) At HRegionServer.java:org.apache.hadoop.hbase.regionserver.HRegionServer.buildServerLoad(long, long) At HRegionServer.java:[line 1393] | | Failed junit tests | hadoop.hbase.regionserver.TestMetricsRegionServer | | | hadoop.hbase.regionserver.TestMetricsUserAggregate | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/722 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 697e8b390b36 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh | | git revision | master / 6aec958d66 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-hadoop-compat.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-hadoop2-compat.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-server.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-hbtop.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-javadoc-javadoc-hbase-hadoop-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-javadoc-javadoc-hbase-hbtop.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/new-findbugs-hbase-hadoop2-compat.html | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/new-findbugs-hbase-client.html | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/testReport/ | | Max. process+thread count | 694 (vs. ulimit of 10000) | | modules | C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
