infraio commented on a change in pull request #721: HBASE-23170 Admin#getRegionServers use ClusterMetrics.Option.SERVERS_NAME URL: https://github.com/apache/hbase/pull/721#discussion_r334767895
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterMetrics.java ########## @@ -104,6 +104,7 @@ public void testDefaults() throws Exception { defaults.getLiveServerMetrics().size()); Assert.assertEquals(origin.getMasterInfoPort(), defaults.getMasterInfoPort()); Assert.assertEquals(origin.getServersName().size(), defaults.getServersName().size()); + Assert.assertEquals(ADMIN.getRegionServers().size(), defaults.getServersName().size()); Review comment: Why add this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services