binlijin commented on a change in pull request #720: HBASE-22370 ByteBuf LEAK ERROR URL: https://github.com/apache/hbase/pull/720#discussion_r334902989
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java ########## @@ -166,7 +166,7 @@ private void release(int mask) { } @Override - public void cleanup() { + public synchronized void cleanup() { Review comment: This method can be called by Handler or Netty Worker concurrently. But releaseByWAL do not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services