Apache9 commented on a change in pull request #720: HBASE-22370 ByteBuf LEAK ERROR URL: https://github.com/apache/hbase/pull/720#discussion_r334917207
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java ########## @@ -550,6 +550,10 @@ private void endBlock() throws IOException { */ @Override public void recoverAndClose(CancelableProgressable reporter) throws IOException { + if (buf != null) { Review comment: So we missed this. Nice catch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services