VladRodionov commented on a change in pull request #623: HBASE-22749:
Distributed MOB compactions
URL: https://github.com/apache/hbase/pull/623#discussion_r335752452
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
##########
@@ -561,91 +553,43 @@ public static Cell createMobRefCell(Cell cell, byte[]
fileName, byte[] refCellTa
public static StoreFileWriter createWriter(Configuration conf, FileSystem fs,
ColumnFamilyDescriptor family, String date, Path basePath, long
maxKeyCount,
Compression.Algorithm compression, String startKey, CacheConfig
cacheConfig,
- Encryption.Context cryptoContext, boolean isCompaction)
+ Encryption.Context cryptoContext, boolean isCompaction, String
regionName)
throws IOException {
MobFileName mobFileName = MobFileName.create(startKey, date,
- UUID.randomUUID().toString().replaceAll("-", ""));
+ UUID.randomUUID().toString().replaceAll("-", ""), regionName);
return createWriter(conf, fs, family, mobFileName, basePath, maxKeyCount,
compression,
cacheConfig, cryptoContext, isCompaction);
}
- /**
- * Creates a writer for the ref file in temp directory.
- * @param conf The current configuration.
- * @param fs The current file system.
- * @param family The descriptor of the current column family.
- * @param basePath The basic path for a temp directory.
- * @param maxKeyCount The key count.
- * @param cacheConfig The current cache config.
- * @param cryptoContext The encryption context.
- * @param isCompaction If the writer is used in compaction.
- * @return The writer for the mob file.
- * @throws IOException
- */
- public static StoreFileWriter createRefFileWriter(Configuration conf,
FileSystem fs,
- ColumnFamilyDescriptor family, Path basePath, long maxKeyCount,
CacheConfig cacheConfig,
- Encryption.Context cryptoContext, boolean isCompaction)
- throws IOException {
- return createWriter(conf, fs, family,
- new Path(basePath, UUID.randomUUID().toString().replaceAll("-", "")),
maxKeyCount,
- family.getCompactionCompressionType(), cacheConfig, cryptoContext,
- HStore.getChecksumType(conf), HStore.getBytesPerChecksum(conf),
family.getBlocksize(),
- family.getBloomFilterType(), isCompaction);
- }
- /**
- * Creates a writer for the mob file in temp directory.
- * @param conf The current configuration.
- * @param fs The current file system.
- * @param family The descriptor of the current column family.
- * @param date The date string, its format is yyyymmmdd.
- * @param basePath The basic path for a temp directory.
- * @param maxKeyCount The key count.
- * @param compression The compression algorithm.
- * @param startKey The start key.
- * @param cacheConfig The current cache config.
- * @param cryptoContext The encryption context.
- * @param isCompaction If the writer is used in compaction.
- * @return The writer for the mob file.
- * @throws IOException
- */
- public static StoreFileWriter createWriter(Configuration conf, FileSystem fs,
- ColumnFamilyDescriptor family, String date, Path basePath, long
maxKeyCount,
- Compression.Algorithm compression, byte[] startKey, CacheConfig
cacheConfig,
- Encryption.Context cryptoContext, boolean isCompaction)
- throws IOException {
- MobFileName mobFileName = MobFileName.create(startKey, date,
- UUID.randomUUID().toString().replaceAll("-", ""));
- return createWriter(conf, fs, family, mobFileName, basePath, maxKeyCount,
compression,
- cacheConfig, cryptoContext, isCompaction);
- }
+// /**
+// * Creates a writer for the mob file in temp directory.
+// * @param conf The current configuration.
+// * @param fs The current file system.
+// * @param family The descriptor of the current column family.
+// * @param date The date string, its format is yyyymmmdd.
+// * @param basePath The basic path for a temp directory.
+// * @param maxKeyCount The key count.
+// * @param compression The compression algorithm.
+// * @param startKey The start key.
+// * @param cacheConfig The current cache config.
+// * @param cryptoContext The encryption context.
+// * @param isCompaction If the writer is used in compaction.
+// * @return The writer for the mob file.
+// * @throws IOException
+// */
+// public static StoreFileWriter createWriter(Configuration conf, FileSystem
fs,
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
