mymeiyi commented on a change in pull request #721: HBASE-23170 
Admin#getRegionServers use ClusterMetrics.Option.SERVERS_NAME
URL: https://github.com/apache/hbase/pull/721#discussion_r335835232
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlacementMaintainer.java
 ##########
 @@ -204,9 +202,7 @@ private void genAssignmentPlan(TableName tableName,
 
     // Get the all the region servers
     List<ServerName> servers = new ArrayList<>();
-    servers.addAll(
-      
FutureUtils.get(getConnection().getAdmin().getClusterMetrics(EnumSet.of(Option.LIVE_SERVERS)))
-        .getLiveServerMetrics().keySet());
+    
servers.addAll(FutureUtils.get(getConnection().getAdmin().getRegionServers()));
 
 Review comment:
   It's a async admin and does not need to close.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to