busbey commented on a change in pull request #623: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/623#discussion_r336715464
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobConstants.java ########## @@ -55,33 +55,23 @@ public static final long DEFAULT_MOB_CACHE_EVICT_PERIOD = 3600L; public final static String TEMP_DIR_NAME = ".tmp"; - public final static String BULKLOAD_DIR_NAME = ".bulkload"; Review comment: We're not supposed to make binary incompatible changes to IA.Public classes except after a deprecation cycle. for the master branch we'll either need to mark it deprecated with expected removal in 4.0, or we'll need to call it out in the release note as removed before then and why that was necessary. I'd just deprecate it. in any case we'll need to make sure it doesn't get removed in any backports. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
