Apache9 commented on a change in pull request #732: HBASE-23187 Update parent 
region state to SPLIT in meta
URL: https://github.com/apache/hbase/pull/732#discussion_r336764481
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 ##########
 @@ -1580,6 +1580,7 @@ public static void splitRegion(Connection connection, 
RegionInfo parent, long pa
       Put putParent = 
makePutFromRegionInfo(RegionInfoBuilder.newBuilder(parent)
                         .setOffline(true)
                         .setSplit(true).build(), time);
+      addRegionStateToPut(putParent, State.SPLIT);
 
 Review comment:
   I think for split, it is SPLIT_PARENT? And what is the way we do this for 
branch-1? In the above code, the RegionInfo has been set to offline and also 
split, so I do not think it should come back online again? If it does then 
there are some bugs in other places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to