wchevreuil commented on a change in pull request #733: HBASE-23191 EOFE log spam
URL: https://github.com/apache/hbase/pull/733#discussion_r336937417
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
##########
@@ -418,7 +418,7 @@ protected boolean readNext(Entry entry) throws IOException
{
"current position and original position match at {}",
originalPosition);
seekOnFs(0);
} else {
- LOG.info("Reached the end of file at position {}",
originalPosition);
+ LOG.debug("Reached the end of file at position {}",
originalPosition);
Review comment:
How much overhead would you think this creates on the logs? As someone who
had been troubleshooting _replication stuck_ issues for the last 5+ years, I
really think it's useful having that information right away, without needing to
reset log level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
