joshelser commented on a change in pull request #740: HBASE-23197
'IllegalArgumentException: Wrong FS' on edits replay when…
URL: https://github.com/apache/hbase/pull/740#discussion_r337100922
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
##########
@@ -314,9 +316,15 @@ public static void archiveStoreFiles(Configuration conf,
FileSystem fs, RegionIn
// build the archive path
if (regionInfo == null || family == null) throw new IOException(
"Need to have a region and a family to archive from.");
-
- Path storeArchiveDir = HFileArchiveUtil.getStoreArchivePath(conf,
regionInfo, tableDir, family);
-
+ String workingDir = conf.get(CommonFSUtils.HBASE_WAL_DIR);
+ Path rootDir = null;
+ if(workingDir == null || !workingDir.startsWith(fs.getScheme())){
Review comment:
The only rule we have with hbase.wal.dir is that it doesn't fall inside of
hbase.rootdir. But, we could also have a wal.dir on a different path, but the
same filesystem, as the store files.
Maybe just a sanity check that, when the `workingDir` includes a
scheme+authority, it doesn't conflict with the scheme of the FileSystem we were
given (indicates a bug on our part).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
