saintstack commented on a change in pull request #739: HBASE-23157 WAL
unflushed seqId tracking may wrong when Durability.AS…
URL: https://github.com/apache/hbase/pull/739#discussion_r337659509
##########
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALRecordReader.java
##########
@@ -193,7 +193,8 @@ public void testWALRecordReader() throws Exception {
WALEdit edit = new WALEdit();
edit.add(new KeyValue(rowName, family, Bytes.toBytes("1"),
System.currentTimeMillis(), value));
- long txid = log.append(info, getWalKeyImpl(System.currentTimeMillis(),
scopes), edit, true);
+ long txid =
+ log.append(info, getWalKeyImpl(System.currentTimeMillis(), scopes),
edit, true, false);
Review comment:
Would it make sense adding an override for append rather than make change
everywhere append is called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
