Apache9 commented on a change in pull request #746: HBASE-23195 FSDataInputStreamWrapper unbuffer can NOT invoke the clas… URL: https://github.com/apache/hbase/pull/746#discussion_r338534673
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java ########## @@ -89,11 +89,6 @@ // reads without hbase checksum verification. private AtomicInteger hbaseChecksumOffCount = new AtomicInteger(-1); - private Boolean instanceOfCanUnbuffer = null; Review comment: I think these two fields are for performance, where we do not need to do instance of and cast everytime, just test a simple flag. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
