[
https://issues.apache.org/jira/browse/HBASE-20910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959289#comment-16959289
]
Ankit Singhal commented on HBASE-20910:
---------------------------------------
It seems [[email protected]] already committed this but forgot to resolve it.
{code}
commit 2eee7a3f8bc9749c10e9d311a55696e66fd0b09d
Author: Ankit Singhal <[email protected]>
Date: Fri Jul 20 15:23:38 2018 -0700
HBASE-20910 Fix dev-support/submit-patch.py by opening file with 'b' mode
Signed-off-by: tedyu <[email protected]>
Signed-off-by: Mike Drob <[email protected]>
{code}
> Fix dev-support/submit-patch.py by opening file with 'b' mode
> -------------------------------------------------------------
>
> Key: HBASE-20910
> URL: https://issues.apache.org/jira/browse/HBASE-20910
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Major
> Attachments: HBASE-20910.patch, HBASE-20910_v1.patch
>
>
> {code:python}
> hbase$ python3.6 dev-support/submit-patch.py
> INFO:submit-patch: Active branch: master
> INFO:submit-patch: Using tracking branch as base branch
> INFO:submit-patch: Base branch: origin/master
> INFO:submit-patch: Patch directory: /Users/asinghal/patches
> INFO:submit-patch: Patch name: master.patch
> Traceback (most recent call last):
> File "dev-support/submit-patch.py", line 253, in <module>
> f.write(diff.encode('utf8'))
> TypeError: write() argument must be str, not bytes
> {code}
> [[email protected]], FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
