ramkrish86 commented on a change in pull request #757: HBASE-23196 The
IndexChunkPool’s percentage is hard code to 0.1
URL: https://github.com/apache/hbase/pull/757#discussion_r338917668
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1611,9 +1611,13 @@ protected void initializeMemStoreChunkCreator() {
float initialCountPercentage =
conf.getFloat(MemStoreLAB.CHUNK_POOL_INITIALSIZE_KEY,
MemStoreLAB.POOL_INITIAL_SIZE_DEFAULT);
int chunkSize = conf.getInt(MemStoreLAB.CHUNK_SIZE_KEY,
MemStoreLAB.CHUNK_SIZE_DEFAULT);
+ float indexChunkPercentage =
conf.getFloat(MemStoreLAB.INDEX_CHUNK_PERCENTAGE_KEY,
+ MemStoreLAB.INDEX_CHUNK_PERCENTAGE_DEFAULT);
Review comment:
So now if ARRAY_MAP is used, the user has to make the INDEX_CHUNK+PERCENTAGE
as 0 instead of using the defualt 0.1? May be we should document this then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
