wchevreuil commented on a change in pull request #764: HBASE-23223 Support the offsetLock of bucketCache to use strong ref URL: https://github.com/apache/hbase/pull/764#discussion_r339505555
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/IdReadWriteLockStrongRef.java ########## @@ -0,0 +1,46 @@ +package org.apache.hadoop.hbase.util; + +import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; +import org.apache.yetus.audience.InterfaceAudience; + +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.locks.ReentrantReadWriteLock; + [email protected] +public class IdReadWriteLockStrongRef<T> implements IdReadWriteLock<T> { Review comment: No tests using this _IdReadWriteLockStrongRef_ lock implementation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
