[
https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249338#comment-13249338
]
[email protected] commented on HBASE-5620:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4629/
-----------------------------------------------------------
(Updated 2012-04-07 21:30:32.906966)
Review request for hbase.
Changes
-------
Addressed Stack's comments. For KeyValue, I removed it from the pb Result.
Summary
-------
This is the client protocol part of region interface. The admin protocol part
will be done in a different jira.
The HRegionInterface is still there since the admin part is not done yet. The
other reason is that in case some people still wants the old interface
Filters, comparators and coprocessor parameters are still Writable. They will
be addressed in different jiras.
The existing client interface is not changed so that we don't break existing
clients.
This addresses bug HBASE-5620.
https://issues.apache.org/jira/browse/HBASE-5620
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 0129ee9
src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java 97293aa
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 16e4017
src/main/java/org/apache/hadoop/hbase/client/HConnection.java 5d43086
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 0b783ce
src/main/java/org/apache/hadoop/hbase/client/HTable.java aa7652f
src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java 9903df3
src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java ddcf9ad
src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java 1acbdab
src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java cbfa489
src/main/java/org/apache/hadoop/hbase/io/TimeRange.java d135393
src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 05ae717
src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java f1f06b0
src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 1316457
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
19ae18c
src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 2eb57de
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
4026da0
src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionAdminProtos.java
2169310
src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionClientProtos.java
b36a9c0
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 8a61f7d
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
703e73d
src/main/java/org/apache/hadoop/hbase/regionserver/Leases.java b520f3f
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java
PRE-CREATION
src/main/protobuf/Admin.proto PRE-CREATION
src/main/protobuf/Client.proto PRE-CREATION
src/main/protobuf/RegionAdmin.proto c64d68b
src/main/protobuf/RegionClient.proto 358382b
src/main/protobuf/hbase.proto da78788
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java c7284dc
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
0042468
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
e34d8bc
src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java f2f8ee3
src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java 41616c8
src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
6ed4ba2
src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java b4dcb83
src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java ceca6f5
src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java
cac2989
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
a1bf73b
Diff: https://reviews.apache.org/r/4629/diff
Testing
-------
"mvn -PrunAllTests clean test" is green, except some flaky tests which need to
run again.
Also tested it on a real cluster with ycsb and bigtop.
Thanks,
Jimmy
> Convert the client protocol of HRegionInterface to PB
> -----------------------------------------------------
>
> Key: HBASE-5620
> URL: https://issues.apache.org/jira/browse/HBASE-5620
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
