Apache9 commented on a change in pull request #774: HBASE-23221 Polish the WAL
interface after HBASE-23181
URL: https://github.com/apache/hbase/pull/774#discussion_r340433767
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -223,9 +223,10 @@ private void updateLastFlushedSequenceIds(ServerName sn,
ServerMetrics hsl) {
if (existingValue == null || (l != HConstants.NO_SEQNUM && l >
existingValue)) {
flushedSequenceIdByRegion.put(encodedRegionName, l);
} else if (l != HConstants.NO_SEQNUM && l < existingValue) {
- LOG.warn("RegionServer " + sn + " indicates a last flushed sequence id
("
- + l + ") that is less than the previous last flushed sequence id ("
- + existingValue + ") for region " + Bytes.toString(entry.getKey())
+ " Ignoring.");
+ LOG.warn("{} passed a last-flushed-sequenceid={} less than " +
+ "previous-last-flushed-sequenceid={}; reverting to new value",
+ sn, l, existingValue, Bytes.toString(entry.getKey()));
+ flushedSequenceIdByRegion.put(encodedRegionName, l);
Review comment:
Let's not do this in this patch? This should be resolved by HBASE-23157.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
