wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly
update the position of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#discussion_r340530744
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
##########
@@ -829,8 +830,9 @@ public void testEmptyWALRecovery() throws Exception {
WAL wal =
utility1.getHBaseCluster().getRegionServer(i).getWAL(regionInfo);
Path currentWalPath = DefaultWALProvider.getCurrentFileName(wal);
String walGroupId =
DefaultWALProvider.getWALPrefixFromWALName(currentWalPath.getName());
- Path emptyWalPath = new Path(utility1.getDataTestDir(), walGroupId + "."
+ ts);
- utility1.getTestFileSystem().create(emptyWalPath).close();
+ Path emptyWalPath = new Path(currentWalPath.getParent(), walGroupId +
"." + ts);
Review comment:
Why is this change needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
