[
https://issues.apache.org/jira/browse/HBASE-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249395#comment-13249395
]
Lars Hofhansl commented on HBASE-5746:
--------------------------------------
Matt's comment on parent:
Eventually it would be nice to isolate the code that deals with the fragile
byte[]'s inside HFile blocks into separate src directories or projects. Then
have that code implement interfaces similar to DataBlockEncoder.java. This
would:
* make it more testable, like a normal in-memory data structure without having
to set up heavyweight testing environments
* separate the encoding concerns from IO concerns. after the checksum happens,
encoders/decoders should not even know what an IOException is
* strongly discourage people from modifying anything in the codec packages
without knowing what they're getting into
* ensure the main project code only references the interfaces and not any codec
internals (see if main project compiles without codecs in classpath)
* make it easier for contributors to develop and profile the codecs without
having to become experts in all aspects of hbase
* help to simplify the main project. imagine if the gzip or snappy internals
were sprinkled throughout the regionserver code. yikes.
> HFileDataBlockEncoderImpl uses wrong header size when reading HFiles with no
> checksums (0.96)
> ---------------------------------------------------------------------------------------------
>
> Key: HBASE-5746
> URL: https://issues.apache.org/jira/browse/HBASE-5746
> Project: HBase
> Issue Type: Sub-task
> Components: io, regionserver
> Reporter: Lars Hofhansl
> Fix For: 0.96.0
>
> Attachments: 5720-trunk-v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
