BukrosSzabolcs commented on issue #675: HBASE-23085: Network and Data related Actions URL: https://github.com/apache/hbase/pull/675#issuecomment-547995525 Hi @joshelser - Updated the javadoc as requested - It makes sense to only corrupt HFiles. It should also make the monkey much less destructive. I went ahead and restricted the functionality. - I'm not sure if additional documentation is necessary. I created separate factories for the new monkey actions so they would not affect existing setups. Also if someone choose to use them customizing the values is very straightforward. We check regular application properties for monkey related ones. If the integration test is run from the command line it is also possible to add a "monkeyProps" option to specify a property file to use for this run on top of the regular properties. There is nothing new here. - The only thing I would like to stress is that the TC actions require passwordless ssh between the machines in the cluster. It is mentioned in the comments, but if you think that is not enough please let me know where else I should mention it. - Discussed those points with Balázs and he said they are fine like this. I'll ask him to leave a comment
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
