[jira] [Commented] (HBASE-23234) Checkstyle and formatter disagree on indentation

[Nick Dimiduk (Jira)]

    [ 
https://issues.apache.org/jira/browse/HBASE-23234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963265#comment-16963265
 ] 

Nick Dimiduk commented on HBASE-23234:
--------------------------------------

Here's another example.

{noformat}
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:3042:
            metricsRegionServer.updatePut(: 'else' child has incorrect 
indentation level 12, expected level should be 14. [Indentation]
{noformat}

formatter gives
{noformat}
          } else {
            metricsRegionServer.updatePut(
{noformat}

checkstyle expects
{noformat}
          } else {
              metricsRegionServer.updatePut(
{noformat}


> Checkstyle and formatter disagree on indentation
> ------------------------------------------------
>
>                 Key: HBASE-23234
>                 URL: https://issues.apache.org/jira/browse/HBASE-23234
>             Project: HBase
>          Issue Type: Task
>          Components: build, tooling
>            Reporter: Nick Dimiduk
>            Priority: Major
>
> I don't have an exhaustive analysis of the issue, but there's at least one 
> case where check style plugin configuration disagrees with our settings in 
> {{dev-support/hbase_eclipse_formatter.xml}}.
> Formatter settings produce this code chunk
> {noformat}
>       uncaughtExceptionHandler =
>           (t, e) -> abort("Uncaught exception in executorService thread " + 
> t.getName(), e);
> {noformat}
> but check style wants
> {noformat}
>       uncaughtExceptionHandler =
>         (t, e) -> abort("Uncaught exception in executorService thread " + 
> t.getName(), e);
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)