saintstack commented on a change in pull request #775: HBASE-23230 Enforce
member visibility in HRegionServer
URL: https://github.com/apache/hbase/pull/775#discussion_r340819870
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -1757,12 +1762,12 @@ public GetOnlineRegionResponse getOnlineRegion(final
RpcController controller,
try {
checkOpen();
requestCount.increment();
- Map<String, HRegion> onlineRegions = regionServer.onlineRegions;
+ Map<String, HRegion> onlineRegions = regionServer.getOnlineRegions();
List<RegionInfo> list = new ArrayList<>(onlineRegions.size());
for (HRegion region: onlineRegions.values()) {
list.add(region.getRegionInfo());
}
- Collections.sort(list, RegionInfo.COMPARATOR);
+ list.sort(RegionInfo.COMPARATOR);
Review comment:
Good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
