bharathv commented on a change in pull request #773: HBASE-23212 : Dynamically reload configs for Region Recovery chore URL: https://github.com/apache/hbase/pull/773#discussion_r340849982
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java ########## @@ -171,4 +167,20 @@ private void prepareTableToReopenRegionsMap( } + // hashcode/equals implementation to ensure at-most one object of RegionsRecoveryChore Review comment: This seems very subtle but in general I think there should be an invariant somewhere that guarantees this rather than silently relying on hashCode() implementations. I'll let the committer take a deeper look at this since I'm new here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
