wchevreuil commented on issue #764: HBASE-23223 Support the offsetLock of bucketCache to use strong ref URL: https://github.com/apache/hbase/pull/764#issuecomment-549035452 Thanks for the updates @bsglz ! Latest refactorings lgtm! > If use strong reference obj pool, should we limit the capacity of the pool? otherwise, there will be the risk of OOM. maybe an StrongObjectPool with RingBuffer based is more suitable? just a suggestion. Very good point, @chenxu14 ! >Consider in most time the count of offset is limited, so i think it is not a problem easily occur,maybe we can improve it in future. Agreed, I think a subtask jira of this current one would be great. > BTW,i have running with it in my live cluster than a week, with 32g heap,70g bucketCache and 16k blockSize,and seems good. That's good. Would u mind collecting&sharing some heap usage/GC stats, together with overall RS metrics (such as write/read requests, compactions, etc) from few days period?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
